Add missing fossils for gen iv#1495
Open
Machine-Maker wants to merge 3 commits intoPokeAPI:masterfrom
Open
Conversation
Machine-Maker
commented
Apr 19, 2026
Member
|
Hi! To me it looks fine but I didn't check the data/v2/csv/encounter_condition_value_map.csv and data/v2/csv/encounters.csv file. If @notblisy or @ItsMeJoji have some time maybe they could help us here |
jemarq04
suggested changes
May 3, 2026
Member
jemarq04
left a comment
jemarq04
left a comment
There was a problem hiding this comment.
I think some IDs got swapped around as the encounter conditions don't match the Pokemon (e.g. Aerodactyl has item-skull-fossil instead of item-old-amber).
I'll do a review once that's been fixed, but @notblisy and @ItsMeJoji please add on as well if you have any comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change description
AI coding assistance disclosure
Used claude code to analyze the csv files to help me understand the structure and identify ids of existing elements to re-uses.
Contributor check list